Skip to content
This repository was archived by the owner on May 12, 2018. It is now read-only.

Conversation

mongris
Copy link

@mongris mongris commented Jul 19, 2013

Fix: Close SPAN tag when using default text color.
Improve: Erase line works fine (escape[2K)
Improve: Cleanup other terminal control escape sequences

@jacobvosmaer
Copy link
Contributor

Thanks for resubmitting @mongris. Could you show us the before/after of your improvements with screenshots?

@mongris
Copy link
Author

mongris commented Jul 19, 2013

Close SPAN tag when using default text color
before:
screen shot 2013-07-19 at 5 44 31
after:
screen shot 2013-07-19 at 5 46 12

Erase line works fine (escape[2K)
before:
screen shot 2013-07-19 at 5 44 56
after:
screen shot 2013-07-19 at 5 46 01

* upstream/master:
  allow sing in with GitLab email or login
  Minor tweak to install docs for postgres.
@@ -12,11 +12,15 @@ module Ansi2html
'90' => 'grey'
}

def self.convert(ansi)
def self.convert(ansi)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4bd58d4 on mongris:master into 5cbfd40 on gitlabhq:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4bd58d4 on mongris:master into 5cbfd40 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4bd58d4 on mongris:master into 5cbfd40 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling bf43395 on mongris:master into 5cbfd40 on gitlabhq:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cb6cac6 on mongris:master into 5cbfd40 on gitlabhq:master.

mongris added 3 commits July 20, 2013 14:50
* upstream/master:
  Update installation.md
  Update installation.md
  Introduced $APP_USER var for running the service
  close #229: Added CSS rules for Firefox, Opera and IE to wrap the trace of a build
  Serving gravatar images form an https source This is safe to run on gitlab-ci http and https servers
* upstream/master:
  Create dirs for sockets and pids (otherwise GitLab CI service fails to start correctly)
  Update installation.md
@coveralls
Copy link

Coverage Status

Coverage decreased (-0%) when pulling 3c5683b on mongris:master into 14110af on gitlabhq:master.

@mongris mongris closed this Jul 26, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants