Skip to content
This repository was archived by the owner on May 12, 2018. It is now read-only.

Conversation

anapsix
Copy link
Contributor

@anapsix anapsix commented Oct 17, 2014

As per conversation with @dosire, I'l like to add the mention of the GitLab-CI Docker image I've build.
I'm not exactly sure how you'd like to word it or section to place it within, so feel free to throw this away and use your own wording...
Thanks GitLabHQ

As per conversation with @dosire, I'l like to add the mention of the GitLab-CI Docker image I've build.
I'm not exactly sure how you'd like to word it or section to place it within, so feel free to throw this away and use your own wording...
Thanks GitLabHQ
@ayufan
Copy link
Member

ayufan commented Oct 17, 2014

Wouldn't it be better to have VOLUME directive for sqlite DB and Logs in Dockerfile?

dosire added a commit that referenced this pull request Oct 17, 2014
@dosire dosire merged commit 7d51134 into gitlabhq:master Oct 17, 2014
@dosire
Copy link
Member

dosire commented Oct 17, 2014

@anapsix Thanks, and please look into the remark of @ayufan

@anapsix anapsix deleted the patch-1 branch October 21, 2014 20:51
@anapsix
Copy link
Contributor Author

anapsix commented Oct 21, 2014

@ayufan yeah, that would be smart ;)
I'll update Dockerfile with VOLUME directives

@ayufan
Copy link
Member

ayufan commented Oct 21, 2014

Great :)

One note there is some guy out there which did docker image for GitLab (https://github.com/sameersbn/docker-gitlab). He also has one for GitLab CI (https://github.com/sameersbn/docker-gitlab-ci) maybe you could add sqlite support for his image?

@anapsix
Copy link
Contributor Author

anapsix commented Oct 21, 2014

I suppose I could.. it was easy enough to do in mine.. though, there is a SQLite3 support pull request for GitLab-CI itself

@dosire
Copy link
Member

dosire commented Oct 22, 2014

I'm not sure we want to support SQLite, this has not worked out well for the main GitLab project.

@anapsix
Copy link
Contributor Author

anapsix commented Oct 22, 2014

clearly a proper DB is a must, but as I understand ActiveRecord allows SQLite out of the box, which is helpful during development, testing or running in a very small environment. Perhaps, I don't understand all implications of supporting it.. Certainly, it is your decision to make.

@dosire
Copy link
Member

dosire commented Oct 22, 2014

@anapsix Clearly SQLite is a great product, but we don't recommend it for GitLab (CI) and don't test against it.

@ayufan
Copy link
Member

ayufan commented Oct 22, 2014

It's easily get blocked with any insert on larger databases. I agree that is unusable in production environment, but maybe it would be wise to have it as option during :development?

@dosire
Copy link
Member

dosire commented Oct 22, 2014

@ayufan We found that for a complex app SQLite is too different from PostgeSQL/MySQL.

@ayufan
Copy link
Member

ayufan commented Oct 22, 2014

Ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants