-
Notifications
You must be signed in to change notification settings - Fork 313
Docker Image mention #483
Docker Image mention #483
Conversation
As per conversation with @dosire, I'l like to add the mention of the GitLab-CI Docker image I've build. I'm not exactly sure how you'd like to word it or section to place it within, so feel free to throw this away and use your own wording... Thanks GitLabHQ
Wouldn't it be better to have VOLUME directive for sqlite DB and Logs in Dockerfile? |
@ayufan yeah, that would be smart ;) |
Great :) One note there is some guy out there which did docker image for GitLab (https://github.com/sameersbn/docker-gitlab). He also has one for GitLab CI (https://github.com/sameersbn/docker-gitlab-ci) maybe you could add sqlite support for his image? |
I suppose I could.. it was easy enough to do in mine.. though, there is a SQLite3 support pull request for GitLab-CI itself |
I'm not sure we want to support SQLite, this has not worked out well for the main GitLab project. |
clearly a proper DB is a must, but as I understand ActiveRecord allows SQLite out of the box, which is helpful during development, testing or running in a very small environment. Perhaps, I don't understand all implications of supporting it.. Certainly, it is your decision to make. |
@anapsix Clearly SQLite is a great product, but we don't recommend it for GitLab (CI) and don't test against it. |
It's easily get blocked with any insert on larger databases. I agree that is unusable in production environment, but maybe it would be wise to have it as option during :development? |
@ayufan We found that for a complex app SQLite is too different from PostgeSQL/MySQL. |
Ok |
As per conversation with @dosire, I'l like to add the mention of the GitLab-CI Docker image I've build.
I'm not exactly sure how you'd like to word it or section to place it within, so feel free to throw this away and use your own wording...
Thanks GitLabHQ