Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu install script] Deprecate the one with 4.2 version and merge one of the existing PRs #129

Closed
axilleas opened this issue Sep 18, 2013 · 7 comments

Comments

@axilleas
Copy link
Contributor

Just a reminder.

@ghost ghost assigned axilleas Sep 18, 2013
@axilleas
Copy link
Contributor Author

axilleas commented Oct 5, 2013

#135 and #136 provide same functionality more or less.

@doublerebel and @tripflex is there any possibility you could somehow cooperate and provide a super script combined from your individual ones?

I'd like to merge both of them, so that anyone can use them, but we'd have to somehow make them distinguishable, starting from their name. So, if there is any possibility you could work together in order to merge them into one, that would be awesome. What do you guys think?

@tripflex
Copy link

tripflex commented Oct 5, 2013

Yup not a problem, i'm working on it right now and will add support for choosing Apache or Nginx, as well as additional options from doublerebel's script.

@tripflex
Copy link

tripflex commented Oct 6, 2013

Okay so i've combined most of everything together, and started on the Apache section, but there's still a little bit that needs to be done.

TODO:
apache
debug
gitlab-ci support
update README
test postgres
test older/newer versions of Ubuntu/Debian (only tested on 12.04 so far)
code cleanup

You can see what i've gotten done so far under the recipes branch for igitlab:
https://github.com/tripflex/igitlab/tree/recipes

I'll have something in a day or two, i'll keep track of everything in that branch from link above. Once everything has been tested i'll move it to the fork and then submit another pull request..

@tripflex
Copy link

tripflex commented Oct 9, 2013

Can someone test this out for me as well and let me know if any problems arise?

@axilleas
Copy link
Contributor Author

Sorry can't test right now, will do when I find some time.

@tripflex
Copy link

No problem i've been swamped with other projects, i'll setup some vagrants and test on them, but so far it looks to work fine on Ubuntu 12.04, hopefully by next week i'll have some real tests completed.

@cgorman
Copy link

cgorman commented Nov 1, 2013

I'm a goober and didn't read the open issues before I did everything, but I put in a PR, #150, for an updated version of the existing script for 6.2. If you want, you could publish that while the other ones are being tested, or just close it and call it a day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants