This repository was archived by the owner on May 12, 2018. It is now read-only.
submodules in diff #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: blob_entry[:name], | ||
| data: "", | ||
| path: path, | ||
| commit_id: sha, |
|
@skv-headless please add description to your PR |
|
@randx fixed and rebased. |
|
@randx ping |
| @@ -55,6 +55,11 @@ def to_hash | |||
| hash | |||
| end | |||
|
|
|||
| def submodule? | |||
| #TODO NOTE FIXME added submodules a_mode is nil in grit | |||
There was a problem hiding this comment.
is it ok to leave it as is?
There was a problem hiding this comment.
I don't know it's a bug in grit. a_mode is nil in grit that's way I can't hide "View file" button here https://cloud.githubusercontent.com/assets/1488195/3720833/2900e428-165a-11e4-9826-5687e44d8b1d.png.
I'm not sure that it's possible to fix now.
skv-headless
force-pushed
the
submodule-method
branch
from
ca1613d to
292902b
Compare
| Blob.new( | ||
| id: blob_entry[:oid], | ||
| name: blob_entry[:name], | ||
| data: "", |
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
skv-headless
force-pushed
the
submodule-method
branch
from
292902b to
5969366
Compare
|
Rebased. @randx please take a look. |
|
We have a lot of submodules. It's confusing when you don't see that they have been updated. Please give me any feedback. |
|
@skv-headless Looks good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repository.blob_at also find submodules
related to gitlabhq/gitlabhq#7389