Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor issue and edit MR form label and submit. #7802

Merged

Conversation

cirosantilli
Copy link
Contributor

This is a direct continuation of: #7678

I had left it out because they were harder to factor, but I think I've manged now.

There should be no UI changes.

Implementation notes:

  • this works because link_to [issuable.project, issuable] is magic and redirects to either index or show depending on if issuable already exists or not.
  • that issuable.new_record? is never reached for the Merge request because the new issue and new MR have diverged... but let's leave that in place for when we merge them together.

@TeatroIO
Copy link

I've prepared a stage. Click to open.

@cirosantilli cirosantilli changed the title Factore issue and edit MR form label field. [WIP] Factor issue and edit MR form label and submit. Sep 20, 2014
@cirosantilli cirosantilli changed the title [WIP] Factor issue and edit MR form label and submit. Factor issue and edit MR form label and submit. Sep 20, 2014
@cirosantilli cirosantilli force-pushed the factor-issue-mr-form-label branch 4 times, most recently from b7a1d01 to 77d38ac Compare September 20, 2014 16:09
@Razer6
Copy link
Member

Razer6 commented Sep 22, 2014

@cirosantilli Can you rebase?

@cirosantilli
Copy link
Contributor Author

Done.

@dzaporozhets dzaporozhets merged commit 705fe01 into gitlabhq:master Oct 2, 2014
@cirosantilli cirosantilli deleted the factor-issue-mr-form-label branch October 2, 2014 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants