enable ldap filters for user logins #3

Closed
wants to merge 1 commit into
from

Conversation

5 participants
@dimaj

dimaj commented Jan 7, 2013

This pull request will enable filter queries against ldap which is particularly useful when you have a big ldap directory and want to give access only to a subset of your users to your gitlab instance.

Please note that this pull request was migrated from omniauth-ldap project pull request 22 which was developed and authored by sdeframond and can be accessed at this link: omniauth#22

Dmitry Jerusalimsky
Added support for ldap filters
All credit for this commit belongs to sdeframond. Please refer to this pull request for more details: omniauth#22

@dimaj dimaj referenced this pull request in gitlabhq/gitlabhq Jan 7, 2013

Closed

ldap filters #2497

@nprudhomme

This comment has been minimized.

Show comment
Hide comment
@nprudhomme

nprudhomme Jun 10, 2013

Any news for this merge request ? ldap authent without ldap filter is really annoying

Any news for this merge request ? ldap authent without ldap filter is really annoying

@aquator

This comment has been minimized.

Show comment
Hide comment
@aquator

aquator Aug 10, 2013

+1 here, just wanted to create a pull request with sdeframond's solution

aquator commented Aug 10, 2013

+1 here, just wanted to create a pull request with sdeframond's solution

@opichon

This comment has been minimized.

Show comment
Hide comment
@opichon

opichon Sep 14, 2013

This would really be a useful feature. In fact, we would probably not be able to use gitlab without it.

opichon commented Sep 14, 2013

This would really be a useful feature. In fact, we would probably not be able to use gitlab without it.

@dimaj

This comment has been minimized.

Show comment
Hide comment
@dimaj

dimaj Sep 14, 2013

I wrote a quick howto article which you can find here

dimaj commented Sep 14, 2013

I wrote a quick howto article which you can find here

@ghost ghost referenced this pull request Jan 31, 2014

Merged

Sync with intridea/omniauth-ldap #10

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 1, 2014

@dimaj This should be working with the merge of PR #10.

ghost commented Feb 1, 2014

@dimaj This should be working with the merge of PR #10.

@dimaj

This comment has been minimized.

Show comment
Hide comment
@dimaj

dimaj Feb 12, 2014

Thanks @jhollingsworth for that pull request!
I've just submitted one more pull request (gitlabhq/gitlabhq#6302) that should enable filters in gitlab itself.

dimaj commented Feb 12, 2014

Thanks @jhollingsworth for that pull request!
I've just submitted one more pull request (gitlabhq/gitlabhq#6302) that should enable filters in gitlab itself.

@mkozono mkozono closed this Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment