Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 6: Reference GitHub repository using SSH instead of HTTPS #111

Closed
wants to merge 1 commit into from

Conversation

emadbaqeri
Copy link

Due to the privacy update on GitHub, the normal sign-in with username and password feature has been deprecated. By following step six and adding HTTP remote as an upstream branch for deploying the app by gh-pages, the process is going to be terminated and you'll see an error from GitHub.

@gitname gitname self-assigned this Nov 11, 2022
@gitname gitname changed the title Updated the example bash scrip in step 6 Step 6: Reference GitHub repository using SSH instead of HTTPS Nov 11, 2022
@emadbaqeri emadbaqeri closed this May 21, 2023
@gitname
Copy link
Owner

gitname commented May 21, 2023

Hi @emadbaqeri, sorry I did not provide an update on this PR in several months.

I think there are pros and cons to using SSH vs HTTPS (e.g. SSH requires generating a key pair; HTTPS requires generating a personal access token; the SSH port is blocked by some corporate firewalls; the personal access token is specific to GitHub whereas an SSH key pair can be reused across servers).

The change I plan to make to the tutorial to address the underlying issue (i.e. the inability to push to the remote repo) is to refer the reader to GitHub's documentation about accessing remote repositories via HTTPS URLs (here) and SSH URLs (here). I will leave it to the reader to get himself/herself to the point of being able to push to remote repos.

Thanks again for bringing the issue to my attention. I would like to credit you for doing so. Are you OK with me adding your GitHub avatar to the Contributors section at the bottom of the README? This is optional (I will assume "no" unless I hear otherwise from you).

@emadbaqeri
Copy link
Author

Hi @emadbaqeri, sorry I did not provide an update on this PR in several months.

I think there are pros and cons to using SSH vs HTTPS (e.g. SSH requires generating a key pair; HTTPS requires generating a personal access token; the SSH port is blocked by some corporate firewalls; the personal access token is specific to GitHub whereas an SSH key pair can be reused across servers).

The change I plan to make to the tutorial to address the underlying issue (i.e. the inability to push to the remote repo) is to refer the reader to GitHub's documentation about accessing remote repositories via HTTPS URLs (here) and SSH URLs (here). I will leave it to the reader to get himself/herself to the point of being able to push to remote repos.

Thanks again for bringing the issue to my attention. I would like to credit you for doing so. Are you OK with me adding your GitHub avatar to the Contributors section at the bottom of the README? This is optional (I will assume "no" unless I hear otherwise from you).

Hey there, no worries at all. Thanks for your updating me about the outcome and your idea sounds cool actually. Yeah sure fill free to do so, that would be my honor actually 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants