error while running config output: """git"" ��...

[tomjn]

tomjn/composerpress#4

I use this library in my WordPress plugin, and a user on Windows 7 x64 had this issue:

Getting this error in plugin's page (after admin menu, no other output):

Fatal error: in C:\server\www\dev\wp-content\plugins\composerpress\vendor\gitonomy\gitlib\src\Gitonomy\Git\Repository.php on line 550

Dumping what $error var holds around there nets this gem:

error while running config output: """git"" �� ���� ����७��� ��� ���譥� ��������, �ᯮ��塞�� �ணࠬ��� ��� ������ 䠩���. "

Win7x64

The error persists in current dev-master on line 559

[alexandresalome]

Are you able to reproduce the problem? I don't have Windows machine but internally, it relies on the "git" command in the PATH.

Might it be that the user doesn't have this command available and that the OS outputs some weird error text...

In this case, you need to add a verification for the command. You can try something like:

$failed = false;
try {
    $repo->run('--version');
} catch (\Exception $e) {
    $failed = true;
}

[Rarst]

Yes, the error persist for me. git is correctly installed, in PATH, and working globally.

[alexandresalome]

The output of the process is really weird. Do you have any clue about what it is written in the error output?

[Rarst]

Mystery to me, mangled beyond all recognition... If I dump $process the commandline is "git" "--git-dir" "C:\server\www\dev\wp-content\plugins\a-fresher-cache/.git" "--work-tree" "C:\server\www\dev\wp-content\plugins\a-fresher-cache" "config" "remote.origin.url" and it works perfectly fine in console.

[lyrixx]

Looks like the content is zipped

[lyrixx]

Sorry

[Rarst]

So it seems that process further wraps command line into this cmd /V:ON /E:ON /C "("git" "--git-dir" "C:\server\www\dev\wp-content\plugins\a-fresher-cache/.git" "--work-tree" "C:\server\www\dev\wp-content\plugins\a-fresher-cache" "config" "remote.origin.url") 1>"C:\Temp\sf_7016.tmp" 2>"C:\Temp\sf_7026.tmp""

If I run this in console manually the first temp file contains result (URL as expected) and second it empty (zero bytes).

Still no idea what's up with mangled error stuff.

[Rarst]

Ok, I figured out a fix (via trial, error, and past proc_open() experience):

$process->setEnv( array( 'PATH' => $_SERVER['PATH'] ) );

Late here, so I am sleepy and not sure why Process doesn't just work, will look into it more tomorrow.

[lyrixx]

Process do that. But Gitlib not

[Rarst]

Thanks for merge, confirm as fixed for me. :)

[X-Coder]

For the Admin::init and all the other functions in there, the same fix is also needed in Gitonomy\Git\Admin.php.