Better directory existence check to avoid empty paths in exception #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,8 @@ | |||
| "symfony/process": "^2.3|^3.0" | |||
| }, | |||
| "require-dev": { | |||
| "psr/log": "^1.0" | |||
| "psr/log": "^1.0", | |||
| "phpunit/phpunit": "^4.8" | |||
There was a problem hiding this comment.
I don't think this should be added for two reasons. The first being that the recommendation is to global install phpunit, and the second being that this change is unrelated to the rest of the PR, so should be proposed seperately.
|
@GrahamCampbell That's fine with me, even though I couldn't find anything in the docs about how to test the project. I'm really more interested in the commit that's left now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing a
Repositoryinstance, if the specified directory doesn't exist, therealpathcall with returnfalseand overwrite the old value, which prevents it from being displayed in the exception. This does the trick.Also, I added PHPUnit as a development dependency and wrote a quick how-to to run tests.