Skip to content

Specify PHP requirement #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2018
Merged

Specify PHP requirement #125

merged 1 commit into from
Jan 10, 2018

Conversation

keradus
Copy link
Collaborator

@keradus keradus commented Jan 9, 2018

as for now, we don't know is software compatible with PHP 5.x or 7.x, we are just guessing.
I took 5.3+, as it's lowest job on Travis

@keradus
Copy link
Collaborator Author

keradus commented Jan 9, 2018

failure on 5.3/7+ was fixed on #122 and are not related to this PR.

@lyrixx, could you give a look on this PR and merge it please ?

@lyrixx
Copy link
Member

lyrixx commented Jan 10, 2018

Could you rebase ? Thanks.

@keradus
Copy link
Collaborator Author

keradus commented Jan 10, 2018

rebased

@lyrixx
Copy link
Member

lyrixx commented Jan 10, 2018

Good catch, thanks Dariusz.

@lyrixx lyrixx merged commit d9c0e96 into gitonomy:master Jan 10, 2018
lyrixx added a commit that referenced this pull request Jan 10, 2018
This PR was merged into the 1.0-dev branch.

Discussion
----------

Specify PHP requirement

as for now, we don't know is software compatible with PHP 5.x or 7.x, we are just guessing.
I took 5.3+, as it's lowest job on Travis

Commits
-------

d9c0e96 Specify PHP requirement
@keradus keradus deleted the composer branch January 10, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants