Skip to content

Fix DateTime namespace in return annotations #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2018
Merged

Fix DateTime namespace in return annotations #136

merged 1 commit into from
Nov 28, 2018

Conversation

robbieaverill
Copy link
Contributor

The DateTime class should be in the global namespace rather than relative to the current class

@robbieaverill
Fix DateTime namespace in return annotations
bfc8377 
The DateTime class should be in the global namespace rather than relative to the current class
@robbieaverill
Copy link
Contributor Author

I'm guessing the HHVM test failures are unrelated

@robbieaverill
Copy link
Contributor Author

Friendly bump =)

@lyrixx lyrixx merged commit dc9e480 into gitonomy:master Nov 28, 2018
@robbieaverill robbieaverill deleted the patch-1 branch November 28, 2018 13:29
@robbieaverill
Copy link
Contributor Author

Thanks!

@lyrixx
Copy link
Member

lyrixx commented Nov 28, 2018

Thanks @robbieaverill

@GrahamCampbell @keradus You know you have write access to this repository too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robbieaverill @lyrixx