Skip to content

Allow Symfony Process 5.0 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2019
Merged

Allow Symfony Process 5.0 #152

merged 1 commit into from
Dec 3, 2019

Conversation

samail
Copy link
Contributor

@samail samail commented Nov 23, 2019

#SymfonyHackday

@GrahamCampbell
Copy link
Member

Thanks @samail. Are we sure there are no changes in Symfony 5 that break our code?

@samail
Copy link
Contributor Author

samail commented Nov 24, 2019 via email •
edited
Loading

alexandresalome
alexandresalome approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@alexandresalome alexandresalome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking time to test with Symfony5.

I created #153, that would be a nice enhancement, regarding discussions here. We can still merge the pull-request until then.

@arnedesmedt
Copy link

Can this one be merged pls? Thx!

@GrahamCampbell GrahamCampbell merged commit 5350784 into gitonomy:master Dec 3, 2019
@GrahamCampbell
Copy link
Member

This is now available in v1.2.0. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandresalome alexandresalome alexandresalome approved these changes

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samail @GrahamCampbell @arnedesmedt @alexandresalome @lyrixx