Php only Repository::getsize

[phpfui]

This is the PHP implementation only version of Repository::getSize.

There are a couple of interesting things I discovered while doing this PR.

• Apparently the tests run twice, The second time the repository is bigger.
• The DU command measures in increments of 1000, not 1024, which is also a valid measurement for K in computers. You say tomato, I say ...

So in the first run of the test, the size of the repo comes in just over 69,000 bytes, as measured by PHP and filesize. On the second run of the test, it comes in at over 70,000 bytes. So I changed the test to >= 69.

The second thing I did was put in a max size test, since that may detect a bug where you don't correctly divide by 1000. Don't ask how I know this.

So there is now an upper limit test of 80K, which should be OK for a while.

But in the end, I think the unit tests numbers are the correct numbers for the tests run.

[GrahamCampbell]

Excellent. Thanks for this @phpfui.

[phpfui]

Happy to help. Good catch on variable name. Had changed it early on, but then changed algorithm but did not change it back.

…

On Sat, Mar 21, 2020, 7:35 AM Graham Campbell ***@***.***> wrote: Excellent. Thanks for this @phpfui <https://github.com/phpfui>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#174 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYW6S7LNFFYOBJA3CUXI5TRISQ7ZANCNFSM4LQWVSCQ> .

[GrahamCampbell]

🍻