Detect binary file by NULL byte #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
approved these changes
Apr 24, 2024
| @@ -19,6 +19,8 @@ | |||
| */ | |||
| class Blob | |||
| { | |||
| private const FIRST_FEW_BYTES = 8000; | |||
There was a problem hiding this comment.
Can you add a little comment that point to git source code?
There was a problem hiding this comment.
Added the comment. Is it clear enough?
lyrixx
approved these changes
Apr 24, 2024
| @@ -19,6 +19,8 @@ | |||
| */ | |||
| class Blob | |||
| { | |||
| private const FIRST_FEW_BYTES = 8000; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First wanted to implement this through the use of
git ls-files --eolbut this would require you to know the tree, which is not always known.This comment on stack overflow pointed to the implementation git uses:
https://git.kernel.org/pub/scm/git/git.git/tree/xdiff-interface.c?h=v2.30.0#n187
latest version is unchanged
Closes #218