Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix computed data not assigned to cache
In
Commit.php
andTag.php
the computed value is stored in the class variable$data
but in a (non existing) local$data
variable. Causing recompute when the function is called again.Fix assigning two data types to the same variable
In
CommitParser.php
,LogParser.php
andTagParser.php
a function is called to get the date as a string and assigned to the class variable, only to be parsed as a\DateTime
a line later and assigned to the same variable.Solution used here to to create a temporary variable and parse that as a sate to avoid the class variable being two types.
Fix calling of removed functions that would just return null
In
ReferenceBag.php
theinitialize
has an try around run and the catch expect functions to be available onRuntimeException
that where removed and just return null.This seems to be behavior that is now expected. So if it throws an error a null is used instead of using functions that do not exists.
Please double check this last one. It resembles the what is currently happening, but do not know you want to change this.