Skip to content

Composer fixes and updated the autoloading #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Composer fixes and updated the autoloading #74

wants to merge 2 commits into from

Conversation

GrahamCampbell
Copy link
Member

PSR-0 is deprecated, and we should also be autoloading our tests in autoload-dev. We can easily move to PSR-4 without moving any of the files thus retaining bc for any people still requiring files manually. Let me know if you're fine with actually just moving the files up 2 levels in the interest of keeping things clean.

},
"autoload-dev": {
"psr-4": {
"Gitonomy\\Git\\Tests\": "tests/Gitonomy/Git/Tests/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency I'd use the escaped backslash \\ at the end too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry. Intended too. Typo.

@GrahamCampbell
Copy link
Member Author

Ping @lyrixx.

@lyrixx
Copy link
Member

lyrixx commented Nov 24, 2014

Thanks @GrahamCampbell.

@lyrixx lyrixx closed this in 18ea62e Nov 24, 2014
@GrahamCampbell GrahamCampbell deleted the patch-1 branch November 24, 2014 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants