fix incorrect diff #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2022
Closed
- Upgrade go to 1.18 - Add contribution guidelines, coding guidelines and update changelog
harry-hov
commented
Oct 20, 2022
|
|
||
| ## Contributing | ||
|
|
||
| Gitopia is an open source project and contributions from community are always welcome. Discussion and development of Gitopia majorly take place on the Gitopia via issues and proposals -- everyone is welcome to post bugs, feature requests, comments and pull requests to Gitopia. (read [Contribution Guidelines](CONTRIBUTING.md) and [Coding Guidelines](CodingGuidelines.md). |
There was a problem hiding this comment.
Replace "Gitopia" with "Git Server"?
There was a problem hiding this comment.
In my opinion it's better to say "Gitopia is an open source project" in every repo because each repo can't work in isolation and are tightly coupled to Gitopia
There was a problem hiding this comment.
Okay. but I still think it's a separate project even if it's tightly coupled to Gitopia. Maybe in the future, we can have separate guidelines for "Git Server" and "Gitopia".
- Gitopia guidelines more focused on blockchain best practices
- Git Server more focused on Server and API best practices
It should explicitly convey that you are contributing to "Gitopia" or "Git Server"
|
LGTM |
faza
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-diff PR: sergi/go-diff#120