This repository was archived by the owner on May 30, 2024. It is now read-only.
Fix lock POST API to handle the constraint error in the store #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahingh
commented
Nov 21, 2021
Comment on lines
+11
to
+22
| func (i *Interactor) GetEnv(ctx context.Context, u *ent.User, r *ent.Repo, env string) (*vo.Env, error) { | ||
| config, err := i.SCM.GetConfig(ctx, u, r) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if !config.HasEnv(env) { | ||
| return nil, e.NewError(e.ErrorCodeConfigUndefinedEnv, nil) | ||
| } | ||
|
|
||
| return config.GetEnv(env), nil | ||
| } |
internal/pkg/store/lock.go
Outdated
Comment on lines
109
to
113
| } else if ent.IsConstraintError(err) { | ||
| return nil, e.NewErrorWithMessage( | ||
| e.ErrorCodeEntityUnprocessable, | ||
| "The lock already exist.", | ||
| err) |
There was a problem hiding this comment.
Handle the constraint error in the store
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lock POST API validates if the environment is already locked or not before locking the environment. To simplify, I've fixed to return an
entity_unprocessableerror when the store creates a lock.