Skip to content
This repository was archived by the owner on May 30, 2024. It is now read-only.

Fix the target attr for the external links #355

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Fix the target attr for the external links #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e455bf
Add target attr to the external links
Feb 20, 2022
9d8bde6
Fix errors for react `key`
Feb 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ui/src/components/DeployConfirm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,13 @@ function CommitChange(props: CommitChangeProps): JSX.Element {

return (
<span >
<a href={props.commit.htmlUrl} className="gitploy-link"><strong>{message}</strong></a>
<a
href={props.commit.htmlUrl}
target="_blank"
className="gitploy-link"
>
<strong>{message}</strong>
</a>
{(description.length) ?
<Button size="small" type="text" onClick={onClickHide}>
<Text className="gitploy-code" code>...</Text>
Expand Down
3 changes: 2 additions & 1 deletion ui/src/components/DeploymentStatusSteps.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,13 @@ export default function DeploymentStatusSteps(props: DeploymentStatusStepsProps)
{props.statuses.map((status, idx) => {
return (
<Timeline.Item
key={idx}
color={getStatusColor(status.status)}
style={(idx === props.statuses.length - 1)? {paddingBottom: 0} : {}}
>
<Paragraph style={{margin: 0}}>
<Text strong>{status.description}</Text>
{(status.logUrl !== "")? <Link href={status.logUrl}> View</Link> : <></>}<br/>
{(status.logUrl !== "")? <Link href={status.logUrl} target="_blank"> View</Link> : <></>}<br/>
<Text>Updated</Text> <Text code className="gitploy-code">{status.status}</Text> <Text>at {moment(status.createdAt).format('HH:mm:ss')}</Text>
</Paragraph>
</Timeline.Item>
Expand Down
4 changes: 1 addition & 3 deletions ui/src/views/Deployment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,7 @@ export default function DeploymentView(): JSX.Element {
<Breadcrumb.Item>Deployments</Breadcrumb.Item>
<Breadcrumb.Item>{number}</Breadcrumb.Item>
</Breadcrumb>}
extra={[
reviewBtn,
]}
extra={reviewBtn}
onBack={onBack}
/>
</div>
Expand Down