Skip to content

Conversation

jeanp413
Copy link
Member

@jeanp413 jeanp413 commented Mar 22, 2023

Uses the new segment library @segment/analytics-node, related gitpod-io/gitpod-vscode-desktop#44

Fixes gitpod-io/gitpod#16512

  • Needs adding segment key to secrets in github before merging

How to test

  • Check segments events are send successfully

@jeanp413 jeanp413 requested a review from mustard-mh March 22, 2023 13:20
if (typeof vscode.env.remoteName === 'undefined' || context.extension.extensionKind !== vscode.ExtensionKind.Workspace) {
return undefined;
}

const gitpodContext = await createGitpodExtensionContext(context);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeanp413
Copy link
Member Author

Added the key to secrets, @mustard-mh let me know if it's fine to merge

@jeanp413 jeanp413 merged commit 8a9fb4f into master Mar 27, 2023
@jeanp413 jeanp413 deleted the jp/extended-bonobo branch March 27, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gitpod-code] use segment directly to report analytics
2 participants