Skip to content

Conversation

filiptronicek
Copy link
Member

Description

Related Issue(s)

See Slack

How to test

Release Notes

Documentation

@filiptronicek filiptronicek self-assigned this Apr 24, 2023
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind to have it there as well. Alternatively we can do what @jeanp413 suggested,

  • add a property commit in package.json at publishing time
  • log this property on the startup with info level

I do like logging approach more, since it would be part of export logs.

@@ -19,6 +20,8 @@ export async function activate(context: vscode.ExtensionContext) {
return;
}

gitpodContext.logger.info(`Gitpod Web ${meta.commit || meta.version}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can access package.json like this const packageJSON = context.extension.packageJSON;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, exactly what I was looking for, thanks JP!

Co-authored-by: Jean Pierre <jeanp413@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants