Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] branch details #5791

Open
svenefftinge opened this issue Sep 21, 2021 · 5 comments
Open

[dashboard] branch details #5791

svenefftinge opened this issue Sep 21, 2021 · 5 comments
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale needs visual design team: webapp Issue belongs to the WebApp team

Comments

@svenefftinge
Copy link
Member

We should have a branch detail page, which would show

  • the last and any prebuilds before that
  • a link to remote repo and branch
@svenefftinge svenefftinge added needs visual design feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. labels Sep 21, 2021
@gtsiolis gtsiolis added component: dashboard team: webapp Issue belongs to the WebApp team labels Sep 21, 2021
@gtsiolis gtsiolis self-assigned this Sep 21, 2021
@svenefftinge
Copy link
Member Author

svenefftinge commented Sep 28, 2021

I think the prebuild page already mostly does what we need.
Screenshot 2021-09-28 at 12 40 05

if we change:

  • the breadcrumb (and URL) to use the branch name
  • show previous prebuilds below.

@gtsiolis gtsiolis moved this from Inbox to In Review in [DEPRECATED] Product Engineering Groundwork Sep 29, 2021
@gtsiolis gtsiolis moved this from In Review to Scheduled in [DEPRECATED] Product Engineering Groundwork Sep 29, 2021
@svenefftinge svenefftinge self-assigned this Sep 29, 2021
@svenefftinge svenefftinge moved this from Scheduled to In Progress in [DEPRECATED] Product Engineering Groundwork Sep 29, 2021
@jankeromnes
Copy link
Contributor

jankeromnes commented Sep 30, 2021

@svenefftinge Isn't it actually the Prebuilds (with an 's') page that already does what we want? I.e.

  1. Click on Project to see active Branches
  2. Click on specific Branch to see list of Prebuilds (i.e. just like the current Prebuilds page, but just for one Branch)
  3. Click on specific Prebuild to see the logs

To me, it doesn't make sense to show the logs of one Prebuild, and then a list of "ancestor prebuilds" that you can also click on(?) Or maybe I'm misunderstanding the proposal.

Proof of concept (note the breadcrumbs):

Project (Branches) Branch (Prebuilds) Prebuild (Logs)
Screenshot 2021-09-30 at 17 29 14 Screenshot 2021-09-30 at 17 31 51 Screenshot 2021-09-30 at 17 32 58

@JanKoehnlein
Copy link
Contributor

I don't think this is actually worked on ATM. Removing from groundwork

@gtsiolis
Copy link
Contributor

Removing all assignees until we get back to this.

@stale
Copy link

stale bot commented Feb 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Feb 23, 2022
@stale stale bot closed this as completed Mar 13, 2022
@gtsiolis gtsiolis reopened this Mar 16, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Mar 16, 2022
@gtsiolis gtsiolis added meta: stale This issue/PR is stale and will be closed soon meta: never-stale This issue can never become stale labels Mar 16, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. meta: never-stale This issue can never become stale needs visual design team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

No branches or pull requests

5 participants