Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCODE terminals are automatically created without any visible reason #9531

Closed
axonasif opened this issue Apr 25, 2022 · 13 comments
Closed

VSCODE terminals are automatically created without any visible reason #9531

axonasif opened this issue Apr 25, 2022 · 13 comments
Assignees

Comments

@axonasif
Copy link
Member

Bug description

If you open a workspace, an extra terminal is always created by the supervisor and ide-process(on workspace-restart) with bash as the shell regardless of your default shell settings on VSCODE (I have fish as the default shell, and it does get used if I manually create a terminal)

Steps to reproduce

Please check the video below:
https://www.loom.com/share/5beb29c3548f45dcb9431f52a1e71539

Workspace affected

No response

Expected behavior

No response

Example repository

https://github.com/axonasif/test

Anything else?

cc @schickling

@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jul 31, 2022
@schickling
Copy link

Still an issue

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Jul 31, 2022
@geropl geropl removed this from 🍎 WebApp Team Aug 1, 2022
@akosyakov akosyakov removed this from 🚀 IDE Team Aug 5, 2022
@akosyakov
Copy link
Member

Unfortunately it is standard behaviour from VS Code. If there is no any terminals, it adds our. And since our terminals are added by extensions which is loaded after VS Code Core there is always one new regular terminal from VS Code. I'm not sure how it can be easily improved without changing internals of VS Code.

@schickling
Copy link

While I agree that this should be addressed in VSC longer term, can this be worked around via some sort of script by Gitpod? This issue causes me to add a manual step everything before I'm able to use a project on Gitpod.

@axonasif
Copy link
Member Author

@schickling currently I'm doing it via my dotfiles as a workaround. You can try it if you want.

All Gitpod/IDE created bash($SHELL) terminals get transferred into a global tmux session after task completion.

@schickling
Copy link

This is a very common "papercut" for me as it's a manual step when opening any workspace in Gitpod. Hopefully this gets fixed soon :)

@stale
Copy link

stale bot commented Dec 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Dec 16, 2022
@schickling
Copy link

Still an issue

@axonasif axonasif removed the meta: stale This issue/PR is stale and will be closed soon label Dec 16, 2022
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Dec 21, 2022
@jeanp413
Copy link
Member

I pushed a commit gitpod-io/openvscode-server@69d257e
@axonasif could you test it in tomorrow's insiders

filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 22, 2022
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 23, 2022
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 23, 2022
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Dec 26, 2022
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 3, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 3, 2023
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 5, 2023
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 6, 2023
@jeanp413
Copy link
Member

jeanp413 commented Jan 7, 2023

Closing this for now, for now it's available in insiders, will be available in the next stable release

@jeanp413 jeanp413 closed this as completed Jan 7, 2023
@github-project-automation github-project-automation bot moved this from Scheduled to Done in 🚀 IDE Team Jan 7, 2023
filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 8, 2023
mustard-mh pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 9, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 9, 2023
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Jan 11, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 11, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 12, 2023
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Jan 14, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 16, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 17, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 18, 2023
@schickling
Copy link

Closing this for now, for now it's available in insiders, will be available in the next stable release

What's the rough ETA for this?

@jeanp413
Copy link
Member

jeanp413 commented Jan 20, 2023

What's the rough ETA for this?

first week of February

For insiders, you can set it in your preferences
image

filiptronicek pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 23, 2023
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Jan 25, 2023
jeanp413 added a commit to gitpod-io/openvscode-server that referenced this issue Jan 26, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 26, 2023
akosyakov pushed a commit to gitpod-io/openvscode-server that referenced this issue Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants