Update dotfiles layout in user preferences #10136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtsiolis
commented
May 19, 2022
| <input | ||
| type="text" | ||
| value={dotfileRepo} | ||
| className="w-96 h-9" |
There was a problem hiding this comment.
thought: It's painful to see the custom height here, but does the job for now.
| Add a repository URL that includes dotfiles. Gitpod will clone and install your dotfiles for | ||
| every new workspace. | ||
| Add a repository URL that includes dotfiles. Gitpod will | ||
| <br /> |
There was a problem hiding this comment.
thought: Another hack around the needs to resolve #7639, see relevant comment in #7639 (comment).
| placeholder="e.g. https://github.com/username/dotfiles" | ||
| onChange={(e) => setDotfileRepo(e.target.value)} | ||
| /> | ||
| <button className="secondary ml-2" onClick={() => actuallySetDotfileRepo(dotfileRepo)}> |
There was a problem hiding this comment.
thought: Using the secondary class here, as this does not need to be a primary action across all preferences, see relevant comment in #7639 (comment).
gtsiolis
changed the title
andrew-farries
approved these changes
May 20, 2022
|
Thanks for taking a look, @andrew-farries! 🙌 |
roboquat
added
deployed: webapp
|
Praise: Brilliant! Thanks for updating @andrew-farries / @gtsiolis ! 🚀 |
|
thanks for fixing this! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the spirit of minimum viable changes and shipping, this will update the dotfiles layout in user preferences. 🛹
Cc @filiptronicek @sagor999 @andreafalzetti @loujaybee because #7639
Related Issue(s)
Fixes #7639
How to test
Go to /preferences and notice the improved usability of the dotfiles section along the rest of the preferences options.
Screenshots
Release Notes