Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount Stripe API keys into the usage component #10631

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

andrew-farries
Copy link
Contributor

@andrew-farries andrew-farries commented Jun 13, 2022

Description

Mount the Stripe API keys into the usage component so that they are available to report usage data to the Stripe API.

These are the same API keys that are mounted into the server component (#10563)

Related Issue(s)

Part of #9036

How to test

Manually trigger a werft job for this branch (Notion doc), setting with-payment=true.

In the preview environment for the branch, verify that the usage pod has a /stripe-secrets mount containing Stripe API keys.

Release Notes

NONE
  • /werft with-payment=true

@andrew-farries andrew-farries requested a review from a team June 13, 2022 15:37
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Jun 13, 2022
@andrew-farries
Copy link
Contributor Author

andrew-farries commented Jun 13, 2022

/werft run

👍 started the job as gitpod-build-af-mount-stripe-secret-into-usage-component.1
(with .werft/ from main)

@andrew-farries
Copy link
Contributor Author

andrew-farries commented Jun 13, 2022

/werft run with-payment=true

👍 started the job as gitpod-build-af-mount-stripe-secret-into-usage-component.2
(with .werft/ from main)

The component will need to interact with the stripe api so will need API
keys.
@andrew-farries andrew-farries force-pushed the af/mount-stripe-secret-into-usage-component branch from 2ec0cef to 9c5de61 Compare June 13, 2022 16:15
@andrew-farries andrew-farries marked this pull request as ready for review June 13, 2022 20:23
@geropl
Copy link
Member

geropl commented Jun 14, 2022

/werft run

👍 started the job as gitpod-build-af-mount-stripe-secret-into-usage-component.4
(with .werft/ from main)

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, and volume is mounted ✔️

@roboquat roboquat merged commit 18cf092 into main Jun 14, 2022
@roboquat roboquat deleted the af/mount-stripe-secret-into-usage-component branch June 14, 2022 14:06
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants