[preview] Add config option for cert-issuer #14282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vulkoingim
force-pushed
the
aa/cfg-cert-issuer
branch
from
fa74243 to
329ffc0
Compare
vulkoingim
force-pushed
the
aa/cfg-cert-issuer
branch
from
329ffc0 to
cecc8f8
Compare
felladrin
approved these changes
Oct 31, 2022
mads-hartmann
approved these changes
Oct 31, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add annotations:
cert-issuer- ability to choose the issuer for the cert of the preview env.[zerossl, letsencrypt]recreate-preview- nuke the whole preview infra and recreate from scratch (including deps). Should be used sparingly, does not replacewith-clean-slate-deploymentrecreate-vm==with-clean-slate-deployment, but shorterFix a small issue with passing
with-clean-slate-deployment- where the VM would get recreated twice, since the flag is set for both applies.Related Issue(s)
Fixes https://gitpod.slack.com/archives/C032A46PWR0/p1667198847703189
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide