Skip to content

Enable protected secrets by default #14288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2022
Merged

Enable protected secrets by default #14288

merged 3 commits into from
Nov 2, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Oct 31, 2022

Description

Enable protected secrets by default. This is the follow up to #14083 on the web app side. Now that gen73 has been deployed we do not need to send the protected_secrets feature flag any more in order to enable protected secrets

Related Issue(s)

Fixes #13634

How to test

Release Notes

None

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-fo-protected-secrets-2.3 because the annotations in the pull request description changed
(with .werft/ from main)

@Furisto Furisto force-pushed the fo/protected-secrets-2 branch 2 times, most recently from d7b70ea to 1147dd9 Compare November 2, 2022 11:12
@Furisto Furisto force-pushed the fo/protected-secrets-2 branch from 1147dd9 to 743be2c Compare November 2, 2022 11:32
@Furisto
Copy link
Member Author

Furisto commented Nov 2, 2022

/werft run with-preview cert-issues=letsencrypt

👍 started the job as gitpod-build-fo-protected-secrets-2.17
(with .werft/ from main)

@Furisto Furisto marked this pull request as ready for review November 2, 2022 13:02
@Furisto Furisto requested a review from a team November 2, 2022 13:02
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 2, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

FYI, currently when this PR lands, the WebApp part will likely rollout sooner. This means you'll no longer be receiving the feature flag on the request. It looks like that's not a problem here as you've already handled the default on ws-manager. Just wanted to call that out.

@roboquat roboquat merged commit ad2f82b into main Nov 2, 2022
@roboquat roboquat deleted the fo/protected-secrets-2 branch November 2, 2022 20:25
@Furisto
Copy link
Member Author

Furisto commented Nov 2, 2022

This means you'll no longer be receiving the feature flag on the request. It looks like that's not a problem here as you've already handled the default on ws-manager.

@easyCZ Yep, the changes for the workspace cluster were deployed with gen73 to ensure that we still use protected secrets

@sagor999 sagor999 mentioned this pull request Nov 2, 2022
4 tasks
@Furisto Furisto linked an issue Nov 3, 2022 that may be closed by this pull request
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ws-manager: Unknown feature flag PROTECTED_SECRETS Remove old OTS code
4 participants