-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Enable protected secrets by default #14288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
started the job as gitpod-build-fo-protected-secrets-2.3 because the annotations in the pull request description changed |
22b9c5a
to
0aa2480
Compare
d7b70ea
to
1147dd9
Compare
1147dd9
to
743be2c
Compare
/werft run with-preview cert-issues=letsencrypt 👍 started the job as gitpod-build-fo-protected-secrets-2.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
FYI, currently when this PR lands, the WebApp part will likely rollout sooner. This means you'll no longer be receiving the feature flag on the request. It looks like that's not a problem here as you've already handled the default on ws-manager. Just wanted to call that out.
@easyCZ Yep, the changes for the workspace cluster were deployed with gen73 to ensure that we still use protected secrets |
Description
Enable protected secrets by default. This is the follow up to #14083 on the web app side. Now that gen73 has been deployed we do not need to send the protected_secrets feature flag any more in order to enable protected secrets
Related Issue(s)
Fixes #13634
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide