Skip to content

[public-api] Implement UpdateTeamMember and DeleteTeamMember #14411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Nov 3, 2022

Description

Implements updating team member (setting role) and deleting team members.

Related Issue(s)

How to test

Unit tests
You can see this implementation in #14412, follow test instructions

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@easyCZ
Copy link
Member Author

easyCZ commented Nov 3, 2022

/werft run

👍 started the job as gitpod-build-mp-papi-set-role-delete-member.1
(with .werft/ from main)

@easyCZ easyCZ marked this pull request as ready for review November 3, 2022 21:12
@easyCZ easyCZ requested a review from a team November 3, 2022 21:12
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 3, 2022
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

@easyCZ
Copy link
Member Author

easyCZ commented Nov 4, 2022

/werft run

👍 started the job as gitpod-build-mp-papi-set-role-delete-member.2
(with .werft/ from main)

@easyCZ
Copy link
Member Author

easyCZ commented Nov 4, 2022

/unhold

@roboquat roboquat merged commit 81b94dd into main Nov 4, 2022
@roboquat roboquat deleted the mp/papi-set-role-delete-member branch November 4, 2022 09:09
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants