Skip to content

[JetBrains] Update Gradle to the same version used in other components (v7.3.1) #14435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

felladrin
Copy link
Contributor

Description

In other components from Gitpod we're using Gradle v7.3.1. So we'll also use in jetbrains-test.
image

This fixes this warning [Reported Internally] from VS Code:
image

How to test

Open this branch in gitpod.io using VS Code and confirm if there's no warning about Gradle.

Release Notes

NONE

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @felladrin! 🔮

I can confirm the Gradle error is gone with these changes. ✔️

Still getting the kubectl and java import errors, but this is probably a different issue.

@felladrin felladrin marked this pull request as ready for review November 4, 2022 14:35
@roboquat roboquat merged commit 6892bdf into main Nov 4, 2022
@roboquat roboquat deleted the jetbrains/update-gradle-to-7.3.1 branch November 4, 2022 14:36
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production release-note-none team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants