[preview] Enable ws-daemon cpu limiting #14441
Conversation
|
started the job as gitpod-build-enable-cpu-limiting.1 because the annotations in the pull request description changed |
|
/werft run with-integration-tests=workspace with-clean-slate-deployment 👍 started the job as gitpod-build-enable-cpu-limiting.2 |
|
started the job as gitpod-build-enable-cpu-limiting.3 because the annotations in the pull request description changed |
| | jq ".service.address = $WS_DAEMON_PORT" > /tmp/"$NAME"-"$KIND"-overrides.json | ||
| | jq ".service.address = $WS_DAEMON_PORT" \ | ||
| | jq ".daemon.cpulimit.enabled = true" \ | ||
| | jq ".daemon.cpulimit.totalBandwidth = 12" \ |
There was a problem hiding this comment.
I think we have to consider the case of a large VM.
There was a problem hiding this comment.
I think it's fine. For the large VM the value is correct and if you set the actual total bandwidth for the small VM you are unlikely to get the burst. Which you would want for testing purposes.
There was a problem hiding this comment.
I'm afraid of that it affects the integration time. E.g. there is a k3s test case, and this workspace needs a lot of resources to start up k3s.
I am also concerned that these limitations may deplete resources and cause integration-agent to fail to launch. Can you run the test in a normal VM (not large) and see what happens?
Furisto
force-pushed
the
enable-cpu-limiting
branch
from
1983a20 to
225f46e
Compare
|
@utam0k PTAL |
roboquat
added
deployed: workspace
Description
Enable ws-daemon cpu limiting in preview environments so that it does not have to be manually activated every time when someone wants to work on cpu limiting
Related Issue(s)
n.a.
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide