Automate cpu runtime test #14508
Merged
Automate cpu runtime test #14508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-furisto-test-integration-test-for-14221.10 because the annotations in the pull request description changed |
|
started the job as gitpod-build-furisto-test-integration-test-for-14221.11 because the annotations in the pull request description changed |
jenting
reviewed
Nov 8, 2022
Furisto
force-pushed
the
furisto/test-integration-test-for-14221
branch
from
940c3bc to
28f62a2
Compare
utam0k
reviewed
Nov 10, 2022
| ) | ||
|
|
||
| func TestCpuBurst(t *testing.T) { | ||
| f := features.New("cpulimiting").WithLabel("component", "ws-manager").Assess("check cpu limiting", func(_ context.Context, t *testing.T, cfg *envconf.Config) context.Context { |
There was a problem hiding this comment.
I think we have to add a check if there is a configuration to enable CPU limit and if there isn't we should skip the test.
Furisto
force-pushed
the
furisto/test-integration-test-for-14221
branch
2 times, most recently
from
543951c to
78735cd
Compare
|
@utam0k PTAL |
utam0k
reviewed
Nov 14, 2022
|
|
||
| func TestCpuBurst(t *testing.T) { | ||
| f := features.New("cpulimiting").WithLabel("component", "ws-manager").Assess("check cpu limiting", func(_ context.Context, t *testing.T, cfg *envconf.Config) context.Context { | ||
| ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute) |
There was a problem hiding this comment.
Is this time enough to wait for burst?
There was a problem hiding this comment.
It should be enough, but I increased it just in case.
utam0k
reviewed
Nov 14, 2022
| f := features.New("cpulimiting").WithLabel("component", "ws-manager").Assess("check cpu limiting", func(_ context.Context, t *testing.T, cfg *envconf.Config) context.Context { | ||
| ctx, cancel := context.WithTimeout(context.Background(), 5*time.Minute) | ||
| defer cancel() | ||
|
|
There was a problem hiding this comment.
Suggested change
| t.Parallel() | |
Furisto
force-pushed
the
furisto/test-integration-test-for-14221
branch
from
78735cd to
ab42b2d
Compare
utam0k
approved these changes
Nov 15, 2022
|
/unhold |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement an integration test to automate the cpu runtime tests.
Related Issue(s)
Fixes #14221
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide