-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix workspace alerts path #14512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workspace alerts path #14512
Conversation
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
started the job as gitpod-build-as-fix-preview-alert-path.1 because the annotations in the pull request description changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple path corrections as per folder structure here: https://github.com/gitpod-io/gitpod/tree/as/fix-preview-alert-path/operations/observability/mixins/workspace/rules
Co-authored-by: Kyle Brennan <kyle@gitpod.io>
Co-authored-by: Kyle Brennan <kyle@gitpod.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to me!
Over to you @gitpod-io/engineering-delivery-operations-experience !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paths look correct!
Description
In #13850, we split workspace alerts into 2 different folders but forgot to update their paths in the configuration used for previews.
This PR fixes the import pathes.
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide