Skip to content

Fix workspace alerts path #14512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Fix workspace alerts path #14512

merged 3 commits into from
Nov 10, 2022

Conversation

ArthurSens
Copy link
Contributor

@ArthurSens ArthurSens commented Nov 8, 2022

Description

In #13850, we split workspace alerts into 2 different folders but forgot to update their paths in the configuration used for previews.

This PR fixes the import pathes.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

Signed-off-by: ArthurSens <arthursens2005@gmail.com>
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-as-fix-preview-alert-path.1 because the annotations in the pull request description changed
(with .werft/ from main)

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ArthurSens and others added 2 commits November 8, 2022 11:23
Co-authored-by: Kyle Brennan <kyle@gitpod.io>
Co-authored-by: Kyle Brennan <kyle@gitpod.io>
@ArthurSens ArthurSens requested a review from kylos101 November 8, 2022 14:23
Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me!

Over to you @gitpod-io/engineering-delivery-operations-experience !

Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths look correct! :shipit:

@roboquat roboquat merged commit ed23c16 into main Nov 10, 2022
@roboquat roboquat deleted the as/fix-preview-alert-path branch November 10, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants