Autofix: trailing-spaces

[autofix-bot]

No description provided.

[werft-gitpod-dev-com]

annotations in the pull request changed, but user is not allowed to start a job

[ArthurSens]

/werft run with-integration-tests=all

👍 started the job as gitpod-build-autofix-trailing-spaces-421-fork.0
(with .werft/ from main)

[ArthurSens]

@jankeromnes would it be ok if we close this PR?

Otherwise, what do we need to do to move this forward? 🙂

[jankeromnes]

@jankeromnes would it be ok if we close this PR?

Hmm, that's what we've done the past few times (I think this PR comes in every month), but there are in fact several trailing spaces that we could clean up -- independently of the .golden files situation.

Otherwise, what do we need to do to move this forward? 🙂

I think maybe let's do something like this: I'll amend and force-push the fix commit to make it not touch the .golden files (since fixing their generator is sort of a side concern). I think I can get this PR into a mergeable state.

[jankeromnes]

/werft run with-integration-tests=all

👍 started the job as gitpod-build-autofix-trailing-spaces-421-fork.1
(with .werft/ from main)

[jankeromnes]

Many thanks @felladrin! 🎉

Interesting -- there are a few WebApp integration test fails, and a bunch of ws-manager integration test fails.

But these seem quite unrelated to whitespace-only clean-ups. 🤷

WebApp

[test-server] === RUN   TestServerAccess/GetLoggedInUser/it_can_get_a_not_built-in_logged_user
[test-server]     server_test.go:35: cannot get GitpodServer: "cannot access Gitpod server API: \"no suitable user found: make sure there's at least one non-builtin user in the database (e.g. login)\""
[test-server] --- FAIL: TestServerAccess (5.52s)
[test-server]     --- FAIL: TestServerAccess/GetLoggedInUser (5.52s)
[test-server]         --- FAIL: TestServerAccess/GetLoggedInUser/it_can_get_a_not_built-in_logged_user (5.52s)
[test-server] === RUN   TestStartWorkspace
[test-server] === RUN   TestStartWorkspace/CreateWorkspace
[test-server] === RUN   TestStartWorkspace/CreateWorkspace/it_can_run_workspace_tasks
[test-server]     server_test.go:66: cannot get GitpodServer: "cannot access Gitpod server API: \"no suitable user found: make sure there's at least one non-builtin user in the database (e.g. login)\""
[test-server] --- FAIL: TestStartWorkspace (5.24s)
[test-server]     --- FAIL: TestStartWorkspace/CreateWorkspace (5.24s)
[test-server]         --- FAIL: TestStartWorkspace/CreateWorkspace/it_can_run_workspace_tasks (5.24s)
[test-server] FAIL
[test-server] FAIL	github.com/gitpod-io/gitpod/test/tests/components/server	11.369s
[test-server] FAIL

ws-manager

[test-ws-manager]     additional_repositories_test.go:72: cannot wait for workspace start: "workspace instance 968a3529-430d-44d2-ad6f-bcda8030e111 is STOPPING"
[test-ws-manager] --- FAIL: TestAdditionalRepositories (61.69s)
[test-ws-manager]     --- FAIL: TestAdditionalRepositories/additional-repositories (61.69s)
[test-ws-manager]         --- FAIL: TestAdditionalRepositories/additional-repositories/can_open_a_workspace_using_the_additionalRepositories_property (61.69s)
[test-ws-manager]             --- FAIL: TestAdditionalRepositories/additional-repositories/can_open_a_workspace_using_the_additionalRepositories_property/workspace_with_additionalRepositories_using_a_branch (31.55s)
[test-ws-manager]             --- FAIL: TestAdditionalRepositories/additional-repositories/can_open_a_workspace_using_the_additionalRepositories_property/workspace_with_additionalRepositories_also_using_a_branch_in_one_of_the_additionalRepositories (30.14s)

[test-ws-manager]     content_test.go:84: cannot wait for workspace start: "workspace instance d3861237-fee9-459b-b8f0-9139c40a88f2 is STOPPING"
[test-ws-manager] --- FAIL: TestBackup (105.63s)
[test-ws-manager]     --- FAIL: TestBackup/backup (105.63s)
[test-ws-manager]         --- FAIL: TestBackup/backup/it_should_start_a_workspace,_create_a_file_and_successfully_create_a_backup (105.63s)
[test-ws-manager]             --- FAIL: TestBackup/backup/it_should_start_a_workspace,_create_a_file_and_successfully_create_a_backup/classic (29.13s)
[test-ws-manager]             --- FAIL: TestBackup/backup/it_should_start_a_workspace,_create_a_file_and_successfully_create_a_backup/pvc (36.17s)
[test-ws-manager]             --- FAIL: TestBackup/backup/it_should_start_a_workspace,_create_a_file_and_successfully_create_a_backup/pvc-non-gitpodified (40.33s)

[test-ws-manager]     workspace.go:301: attemp to delete the workspace: 9b1ae5bb-b153-484a-bf6a-771f9358a6a5
[test-ws-manager]     workspace.go:327: the workspace is already gone
[test-ws-manager]     content_test.go:235: cannot wait for workspace start: "workspace instance 9b1ae5bb-b153-484a-bf6a-771f9358a6a5 is STOPPING"
[test-ws-manager] --- FAIL: TestExistingWorkspaceEnablePVC (30.07s)
[test-ws-manager]     --- FAIL: TestExistingWorkspaceEnablePVC/backup (30.07s)
[test-ws-manager]         --- FAIL: TestExistingWorkspaceEnablePVC/backup/it_should_enable_PVC_feature_flag_to_the_existing_workspace_without_data_loss (30.07s)

...

Are all these tests typically expected to work?

[felladrin]

Yeah, probably we'll need to rebase this branch.

This branch is 1 commit ahead, 145 commits behind gitpod-io:main.

[jankeromnes]

/werft run with-integration-tests=all

👍 started the job as gitpod-build-autofix-trailing-spaces-421-fork.2
(with .werft/ from main)

[jankeromnes]

/werft run with-integration-tests=all

👍 started the job as gitpod-build-autofix-trailing-spaces-421-fork.3
(with .werft/ from main)

[jankeromnes]

Looks like the build was entirely successful 🎉 but then it timed out after waiting 2h for a VM or something, which I believe is unrelated.

https://werft.gitpod-dev.com/job/gitpod-build-autofix-trailing-spaces-421-fork.3/logs

So, to unblock merging this clean-up, I'll trigger a new build with no preview or tests to ensure that it becomes green.

/werft run

[jankeromnes]

Thanks again for raising this @ArthurSens 🙏 I think we can safely merge this now. As a member of DOPE team, would you mind giving your approval too? 😇