Skip to content

[server] Remove deprecatedDoWatchWorkspaceImageBuildLogs() - unused #14571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Nov 9, 2022

Description

Looks to be entirely unused. There are no references to it, and no invocations in metrics

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@easyCZ easyCZ requested a review from a team November 9, 2022 19:45
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 9, 2022
@easyCZ
Copy link
Member Author

easyCZ commented Nov 10, 2022

/hold to not block Q

@easyCZ easyCZ force-pushed the mp/srv-remove-deprecate-watch-image-build-logs branch from 7c5de48 to 078c0f0 Compare November 10, 2022 08:14
@easyCZ
Copy link
Member Author

easyCZ commented Nov 10, 2022

/unhold

@roboquat roboquat merged commit 9e63939 into main Nov 10, 2022
@roboquat roboquat deleted the mp/srv-remove-deprecate-watch-image-build-logs branch November 10, 2022 08:29
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants