Skip to content

[public-api] Implement DeleteTeam #14573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions components/public-api-server/pkg/apiv1/team.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,25 @@ func (s *TeamService) ListTeams(ctx context.Context, req *connect.Request[v1.Lis
}), nil
}

func (s *TeamService) DeleteTeam(ctx context.Context, req *connect.Request[v1.DeleteTeamRequest]) (*connect.Response[v1.DeleteTeamResponse], error) {
teamID, err := validateTeamID(req.Msg.GetTeamId())
if err != nil {
return nil, err
}

conn, err := s.getConnection(ctx)
if err != nil {
return nil, err
}

err = conn.DeleteTeam(ctx, teamID.String())
if err != nil {
return nil, proxy.ConvertError(err)
}

return connect.NewResponse(&v1.DeleteTeamResponse{}), nil
}

func (s *TeamService) JoinTeam(ctx context.Context, req *connect.Request[v1.JoinTeamRequest]) (*connect.Response[v1.JoinTeamResponse], error) {
if req.Msg.GetInvitationId() == "" {
return nil, connect.NewError(connect.CodeInvalidArgument, fmt.Errorf("invitation id is a required argument to join a team"))
Expand Down
24 changes: 24 additions & 0 deletions components/public-api-server/pkg/apiv1/team_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,30 @@ func TestTeamService_ResetTeamInvitation(t *testing.T) {
})
}

func TestTeamService_DeleteTeam(t *testing.T) {
t.Run("missing team ID returns invalid argument", func(t *testing.T) {
_, client := setupTeamService(t)

_, err := client.DeleteTeam(context.Background(), connect.NewRequest(&v1.DeleteTeamRequest{}))
require.Error(t, err)
require.Equal(t, connect.CodeInvalidArgument, connect.CodeOf(err))
})

t.Run("proxies request to server", func(t *testing.T) {
teamID := uuid.New().String()

serverMock, client := setupTeamService(t)

serverMock.EXPECT().DeleteTeam(gomock.Any(), teamID).Return(nil)

response, err := client.DeleteTeam(context.Background(), connect.NewRequest(&v1.DeleteTeamRequest{
TeamId: teamID,
}))
require.NoError(t, err)
requireEqualProto(t, &v1.DeleteTeamResponse{}, response.Msg)
})
}

func newTeam(t *protocol.Team) *protocol.Team {
result := &protocol.Team{
ID: uuid.New().String(),
Expand Down