Skip to content

[public-api] Add test for CreateToken when feature flag enabled #14709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Nov 15, 2022

Description

Ensures we have coverage for both cases of the feature flag. Currently returns unimplemented, but will be extended in future PRs.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@easyCZ easyCZ requested review from a team November 15, 2022 14:44
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Nov 15, 2022
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@easyCZ easyCZ force-pushed the mp/papi-tokens-create-test-for-flag-enabled branch from 9b6d210 to 6c883c7 Compare November 15, 2022 15:00
@easyCZ
Copy link
Member Author

easyCZ commented Nov 15, 2022

/werft run

👍 started the job as gitpod-build-mp-papi-tokens-create-test-for-flag-enabled.2
(with .werft/ from main)

@easyCZ
Copy link
Member Author

easyCZ commented Nov 15, 2022

/unhold

@roboquat roboquat merged commit d9bd0bf into main Nov 15, 2022
@roboquat roboquat deleted the mp/papi-tokens-create-test-for-flag-enabled branch November 15, 2022 15:25
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Nov 16, 2022
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants