Skip to content

[server] Remove createSubscriptionOnUsage feature flag #14794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Nov 18, 2022

Description

Removes feature flag (and false code-path) for creating subscription on usage.

Also removes reading of Stripe config in server, unused.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@easyCZ easyCZ requested a review from a team November 18, 2022 15:16
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 18, 2022
@laushinka
Copy link
Contributor

Tested already on prod that this flow isn't used.

@laushinka
Copy link
Contributor

Holding due to failing build

/hold

@easyCZ easyCZ force-pushed the mp/server-remove-stripe-feature-flag branch 2 times, most recently from 5019986 to a2c081a Compare November 18, 2022 15:33
@laushinka laushinka force-pushed the mp/server-remove-stripe-feature-flag branch from a2c081a to bb267b6 Compare November 18, 2022 15:47
@easyCZ easyCZ force-pushed the mp/server-remove-stripe-feature-flag branch from bb267b6 to 425b874 Compare November 18, 2022 15:48
@easyCZ easyCZ force-pushed the mp/server-remove-stripe-feature-flag branch from 425b874 to eca109c Compare November 18, 2022 15:49
@easyCZ
Copy link
Member Author

easyCZ commented Nov 21, 2022

/unhold

@roboquat roboquat merged commit 28f8948 into main Nov 21, 2022
@roboquat roboquat deleted the mp/server-remove-stripe-feature-flag branch November 21, 2022 08:13
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants