Skip to content

[projects] ignore user settings for prebuilds #14809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2022
Merged

[projects] ignore user settings for prebuilds #14809

merged 1 commit into from
Nov 21, 2022

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Nov 21, 2022

Description

We don't want to consider user settings for prebuilds. This change removes that consideration.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-payment
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-se-ws-classes.1 because the annotations in the pull request description changed
(with .werft/ from main)

@svenefftinge svenefftinge marked this pull request as ready for review November 21, 2022 07:08
@svenefftinge svenefftinge requested a review from a team November 21, 2022 07:08
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 21, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if there are any implications to PVCs? I remember there being quite a bit of work around PVCs being used for Prebuilds (and then inhering the prebuild for WS start)

@svenefftinge
Copy link
Contributor Author

Do you know if there are any implications to PVCs? I remember there being quite a bit of work around PVCs being used for Prebuilds (and then inhering the prebuild for WS start)

no implications. the PVC suffix is applied post this.

@roboquat roboquat merged commit 710c7ff into main Nov 21, 2022
@roboquat roboquat deleted the se-ws-classes branch November 21, 2022 13:52
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants