Skip to content

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Sep 11, 2023

Description

This change wraps general requests, job runs and redis event handling in their own context so we can group them their log messages.
It also uses the track context id as the contextId on websocket requests and provides a message to users that include that id.

Summary generated by Copilot

🤖 Generated by Copilot at 4bf240e

Improved logging and tracing code in WorkspaceStarter class. Extracted common log context fields to a logCtx variable.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, with this caveat.
Tested and worked.

@svenefftinge
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit e2ae3e3 into main Sep 12, 2023
@roboquat roboquat deleted the se/log-ctx branch September 12, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants