Add sorting to imported repos list and corresponding API #19097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfcontained
changed the title
14 tasks
akosyakov
reviewed
Nov 21, 2023
| } | ||
|
|
||
| message Sort { | ||
| string field = 1; |
There was a problem hiding this comment.
Please add a comment here that it is a field name in camel case 🙏
akosyakov
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
api/server looks good, I did not look at UI, cc @filiptronicek
/hold
components/dashboard/src/components/podkit/tables/SortableTable.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Filip Troníček <filip@gitpod.io>
Co-authored-by: Filip Troníček <filip@gitpod.io>
Co-authored-by: Filip Troníček <filip@gitpod.io>
remove redundant styles Co-authored-by: Filip Troníček <filip@gitpod.io>
…e.tsx Co-authored-by: Filip Troníček <filip@gitpod.io>
remove redundant style Co-authored-by: Filip Troníček <filip@gitpod.io>
Co-authored-by: Filip Troníček <filip@gitpod.io>
selfcontained
force-pushed
the
brad/repo-configs-sortable-headers
branch
from
578f71c to
145cb77
Compare
filiptronicek
approved these changes
Nov 21, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing sorting for ListConfigurations api and the corresponding UI.
Name and Created headers are sortable.
I was hitting a lot of issues trying to keep the headers accessible with proper buttons and the global button styles... so I decided to bite the bullet and remove them, and update all occurrences of
<button>to use our component. There were just a couple spots that I chose to inline the old styles to the button class name to avoid changing things too drastically. There are a couple places that were using thedanger.secondarystyle that I just swapped to use thedestructivevariant.I did my best to test each change and make sure I didn't break anything. Any additional testing would be helpful as well.
Summary generated by Copilot
🤖[deprecated] Generated by Copilot at c489f42
This pull request adds sorting functionality to the configuration service and the configuration list page, using a common sorting model defined in the new
sorting.protofile. It also updates the public API and the dashboard components to support sorting by different fields. It temporarily disables sorting for the repository list page until the repository service supports it.Related Issue(s)
Fixes EXP-946
Fixes EXP-838
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold