Skip to content

wrap menu item w/ separate flag check #19220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

selfcontained
Copy link
Contributor

@selfcontained selfcontained commented Dec 7, 2023

Description

This adds a new feature flag, showRepoConfigMenuItem, which just gates if the Repositories link is present in the org menu. The aim here is to quietly release the new repo config UI for dedicated customers, but keep it hidden in the org menu for them. This lets us reach out individually for feedback from some specific customers.

Summary generated by Copilot

🤖[deprecated] Generated by Copilot at 159760a

This pull request adds a feature flag showRepoConfigMenuItem to hide or show the repository configuration menu item in the organization selector component. It modifies the OrganizationSelector.tsx and featureflag-query.ts files to implement this feature.

How to test

  • Check that the Repositories link is present in the org menu.
  • Join this org w/ the invite link and verify the Repositories link doesn't show up (ff disabled)

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@selfcontained
Copy link
Contributor Author

/gh run recreate-vm=true

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍

image

@selfcontained
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 277c9da into main Dec 8, 2023
@roboquat roboquat deleted the brad/repo-config-menu-flag branch December 8, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants