Skip to content

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Jul 2, 2024

Description

This PR adds a Gitpod repository template to the New workspace component. The template allows users to easily create workspaces with preconfigured demos for Docker Compose and Java with Maven and Spring Boot.

It also adds a new showExamples option to /new (as /new?showExmaples=true) CreateWorkspacePage component. The option allows controlling whether example repositories should be shown.

Screen.Recording.2024-07-02.at.7.04.00.PM.mov

RE: Tracking

It already exist in past, so didn't changed anything, for these repos, we can use either of the method track:

  • No. of workspaces started from those two github repositories (can be slightly incorrect, because repos. are publicly accessible via GitHub, Website docs, etc.)
  • Measuring dashboard_clicked event following labels:
    • label: demo-javagithub.com/gitpod-demos/spring-petclinic (label names are broken since before)
    • label: voting-appgithub.com/gitpod-demos/voting-app

Related Issue(s)

Fixes OPM-656

How to test

  • Open preview environment
  • Complete onboarding
  • Click on New Workspace (/new)
  • Scroll down to the repository list and see 👀
  • Same for /new?showExamples=true

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@roboquat roboquat added size/L and removed size/M labels Jul 2, 2024
@svenefftinge
Copy link
Contributor

Please introduce an explicit query param showExamples for the /new page, that instead of listing your repositories will only list the example repos.

…in order to control whether example repositories should be shown. The option is passed down to the `StartWorkspaceOptions` component and used to conditionally render the examples section.
@Siddhant-K-code
Copy link
Member Author

@svenefftinge: Please introduce an explicit query param showExamples for the /new page, that instead of listing your repositories will only list the example repos.

I've updated it in e03c351

Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my other comment, otherwise LGTM

@Siddhant-K-code
Copy link
Member Author

Siddhant-K-code commented Jul 2, 2024

@svenefftinge it would be helpful, if you can re-review the recent changes 🙏🏻

@Siddhant-K-code
Copy link
Member Author

/unhold

@roboquat roboquat merged commit 2cc42e2 into main Jul 2, 2024
@roboquat roboquat deleted the siddhant/opm-656-add-demo-projects-to-repository-select-on-new-workspace-page branch July 2, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants