Skip to content

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Jul 2, 2024

Description

Context Parsing: We want to throw the actual error message, so users better understand why a request failed.

Screenshot 2024-07-04 at 12 51 34

Related Issue(s)

Fixes https://linear.app/gitpod/issue/ENT-363/properly-propagate-and-display-access-problems-in-multi-repo-setups

How to test

https://se-resolve-error-msg.preview.gitpod-dev.com/new#https://github.com/svenefftinge/gitpod-tasks/tree/broken-reporef

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@svenefftinge svenefftinge force-pushed the se/resolve-error-msg branch from 9efe83b to 056472e Compare July 2, 2024 12:43
@roboquat roboquat added size/M and removed size/S labels Jul 2, 2024
@geropl
Copy link
Member

geropl commented Jul 2, 2024

❤️ The new approach!

@svenefftinge svenefftinge force-pushed the se/resolve-error-msg branch from 056472e to a9208ef Compare July 3, 2024 12:36
@svenefftinge svenefftinge force-pushed the se/resolve-error-msg branch from a9208ef to db13e48 Compare July 4, 2024 10:39
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested and works! ✔️

@svenefftinge
Copy link
Contributor Author

/unhold

@roboquat roboquat merged commit 024f71a into main Jul 4, 2024
@roboquat roboquat deleted the se/resolve-error-msg branch July 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants