[JetBrains] fix latest terminal integration broken #20009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Jul 8, 2024
| <depends optional="true" config-file="maven.xml">org.jetbrains.idea.maven</depends> | ||
| <dependencies> | ||
| <plugin id="Git4Idea"/> | ||
| <plugin id="org.jetbrains.plugins.terminal"/> | ||
| <plugin id="com.jetbrains.codeWithMe"/> | ||
| <!-- <plugin id="org.jetbrains.plugins.terminal"/> --> |
There was a problem hiding this comment.
should not we remove it or it is required in some cases?
There was a problem hiding this comment.
I'll try if not remove it works
There was a problem hiding this comment.
I misunderstand you question. But I believe to keep new format is a good option, old format (changes we made) is about to fix SharedTerminalService class not found exception.
Not sure how we can detect such case: this plugin requires old format in some versions, it's a break change no 🤕?
akosyakov
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Relates private chat
Fixes ENT-426
How to test
✅
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold