Skip to content

Fix changes dropdown alignment #20023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix changes dropdown alignment #20023

merged 1 commit into from
Jul 11, 2024

Conversation

filiptronicek
Copy link
Member

Description

Fixes a regression from #19992 which made the dropdown for git changes incorrectly aligned on the start workspace page.

Old New
image image

It also fixes a focusing issue on the new workspace button and updates the caniuse database, which we haven't done in a while.

How to test

https://ft-fix-cha41e1198b65.preview.gitpod-dev.com/workspaces

Start a workspace, touch a file, stop it and observe the page's UI.

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/chokidar@3.5.3 environment, filesystem +1 102 kB paulmillr
npm/cipher-base@1.0.4 None 0 7.95 kB cwmma
npm/class-variance-authority@0.7.0 None +1 15.7 kB joebell93
npm/classnames@2.3.1 None 0 17.7 kB dcousens
npm/cli-highlight@2.1.11 Transitive: environment, filesystem +4 815 kB felixfbecker
npm/cluster-key-slot@1.1.0 None 0 11.8 kB salakar
npm/colorette@2.0.20 None 0 17 kB jorgebucaran
npm/commander@8.3.0 environment, filesystem, shell 0 151 kB abetomo
npm/component-emitter@1.3.0 None 0 8 kB nami-doc
npm/concurrently@6.3.0 environment, filesystem +1 112 kB gustavohenke
npm/configcat-common@6.0.0 None 0 442 kB configcat
npm/configcat-js@6.0.0 None 0 114 kB configcat
npm/configcat-node@8.0.0 network 0 23.1 kB configcat
npm/content-disposition@0.5.4 None 0 19.1 kB dougwilson
npm/convert-source-map@1.8.0 filesystem 0 10.3 kB thlorenz
npm/cookie-parser@1.4.6 None +2 34.1 kB dougwilson
npm/cookie@0.4.2 None 0 19.7 kB dougwilson
npm/cookiejar@2.1.3 None 0 14.4 kB andyburke
npm/copy-webpack-plugin@11.0.0 Transitive: environment +5 362 kB evilebottnawi
npm/cors@2.8.5 None 0 20 kB dougwilson
npm/cosmiconfig@7.0.1 filesystem +1 93.7 kB davidtheclark
npm/countries-list@2.6.1 None 0 527 kB z-ax
npm/create-ecdh@4.0.4 None 0 5.4 kB cwmma
npm/create-error@0.3.1 None 0 10.4 kB tgriesser
npm/create-hash@1.2.0 None 0 5.21 kB cwmma
npm/create-hmac@1.1.7 None 0 5.81 kB cwmma
npm/cross-spawn@7.0.3 environment, filesystem, shell 0 21.2 kB satazor
npm/crypto-browserify@3.12.0 None 0 53.5 kB cwmma
npm/css-loader@6.8.1 None 0 131 kB evilebottnawi
npm/css-tree@1.1.3 None 0 989 kB lahmatiy
npm/csso@4.2.0 None 0 593 kB lahmatiy

🚮 Removed packages: npm/@types/bun@1.1.2, npm/@types/google-protobuf@3.15.6, npm/@types/node@18.0.4, npm/@types/node@20.12.12, npm/axios@1.7.2, npm/caniuse-lite@1.0.30001521, npm/google-protobuf@3.20.1, npm/grpc-tools@1.12.4, npm/grpc_tools_node_protoc_ts@5.3.2, npm/inherits@2.0.4, npm/long@5.2.3, npm/protobufjs@7.3.2, npm/semver@7.6.2, npm/string-width@4.2.3, npm/strip-ansi@6.0.1, npm/typescript-formatter@7.2.2, npm/typescript@4.4.4, npm/yaml@2.4.2, npm/yargs-parser@21.1.1, npm/yargs@17.7.2, npm/zod@3.23.8

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/core-js@3.32.0
  • Install script: postinstall
  • Source: node -e "try{require('./postinstall')}catch(e){}"
  • orphan: npm/core-js@3.32.0
🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/core-js@3.32.0

Copy link
Contributor

@mustard-mh mustard-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@filiptronicek filiptronicek self-assigned this Jul 11, 2024
@roboquat roboquat merged commit 669cad5 into main Jul 11, 2024
31 of 32 checks passed
@roboquat roboquat deleted the ft/fix-changes-alignment branch July 11, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants