Fix incorrect redirects to newer prebuilds #20047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why this PR could fix the linked issue |
geropl
reviewed
Jul 21, 2024
| ["prebuild-trigger", configurationId, gitRef], | ||
| async () => { | ||
| export function useTriggerPrebuildMutation(configurationId?: string, gitRef?: string) { | ||
| return useMutation({ |
There was a problem hiding this comment.
😮 Wow, nice find! I'm 💯 I reviewed this function this week, and just glanced over this 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The method for triggering a new prebuild is currently a query, because it made it integrating into the UI easier. That came with some unintended consequences in caching though, hence this PR which converts it into a standard mutation.
What happened is that for some reason, the query we used with
cacheTime: 0still kept some cache for quite some time, meaning that going to prebuilds which were not the latest one caused the cache to retrieve the latest triggered prebuild id and redirect to it. This to the user looked like the prebuild they just clicked on was behaving weirdly without status updates, but in fact it was a completely different prebuild.Related Issue(s)
Fixes ENT-471
How to test
https://ft-fix-pre38d051c02d.preview.gitpod-dev.com/repositories
Rerun Prebuild/hold