Support validate claims with CEL expr for SSO
#20083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to configure the preview env now 👀 |
|
And it works nicely! 🥳 |
geropl
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Code LGTM, tested and works! ✔️
There are two nits I have (alignment and a trim() we could sprinkle in) but let's do those separately.
Nice work @mustard-mh !
|
/unblock |
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Relates ENT-561
How to test
Current CEL expression in preview env is
'gitpod-team' in claims.groups_direct || (claims.email_verified && claims.email.endsWith("@gitpod.io"))@gitpod.io, you should be able to logingitpod-team, you should be able to loginSetup Preview envs with Self-hosted / SaaS GitLab
Note
Test should follow https://github.com/gitpod-io/website/pull/4789
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold