[dashboard, server] Fix streaming of image build logs #20095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because json-rpc can't handle complex objects like UInt8Array properly. Conversion is done using "Array.from(UInt8Array)" and "new UInt8Array(data)"
filiptronicek
approved these changes
Aug 8, 2024
| @@ -974,7 +974,7 @@ export namespace WorkspaceImageBuild { | |||
| maxSteps?: number; | |||
| } | |||
| export interface LogContent { | |||
| data: Uint8Array; | |||
| data: number[]; // encode with "Array.from(UInt8Array)"", decode with "new UInt8Array(data)" | |||
There was a problem hiding this comment.
nice find about the json-rpc limitations
Co-authored-by: Filip Troníček <filip@gitpod.io>
|
/unhold |
geropl
added a commit
that referenced
this pull request
Sep 9, 2024
…ace.tsx introduced in #20095 It's unclear as to if that's a real bug, fixing it here is good anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When fixing chunking-issues, we lost sight of some older clients that still use the json-rpc interface, and are constrained by it's limitations. This PR makes sure we only transmit primitive data types.
Related Issue(s)
Fixes ENT-618
Fixes ENT-255 (got too annoying while debugging)
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold