Skip to content

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Aug 23, 2024

Description

Use supervisor mount namespace for nfs mount

Related Issue(s)

Fixes ENT-677

How to test

  • Use this docker compose file
volumes:
  efs:
    driver: local
    driver_opts:
      type: nfs4
      o: nfsvers=4.1,rsize=1048576,wsize=1048576,hard,timeo=600,retrans=2,noresvport,address=
      device: yoursharename:/

services:
  postgres-15:
    user: 33333:33333
    environment:
      POSTGRES_PASSWORD: admin
      PGDATA: /var/lib/gitpod
    image: postgres
    restart: always
    hostname: postgres
    shm_size: 1g
    ports:
      - "5432:5432"
    volumes:
      - efs:/var/lib/gitpod
  • docker compose up
  • Postgres should write its data files to the nfs share

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

cmdline, err := os.ReadFile(filepath.Join(procPath, "cmdline"))
if err != nil {
log.WithField("file", filepath.Join(procPath, "cmdline")).WithError(err).Error("cannot read cmdline")
continue
Copy link
Contributor

@kylos101 kylos101 Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, not blocking:
How come we would not return here? I assume maybe it is because the process could be gone by the time we try to read it?

Copy link
Contributor

@kylos101 kylos101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EFS mount working in my workspace (w/o docker compose):
image

The mount from docker compose is failing given the provided example, so, it needs to be established before running docker compose.

@roboquat roboquat merged commit 47370e2 into main Aug 23, 2024
58 checks passed
@roboquat roboquat deleted the fo/nfs-mount-ns branch August 23, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants