Skip to content

Conversation

mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented Aug 27, 2024

Description

Related Issue(s)

Fixes ENT-538

How to test

See internal chat

Preview env should work well

  • Workspace can start
  • Open with VS Code Browser, Gitpod CLI , JetBrains Gateway, VS Code Browser
  • Can access private port

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=vscode
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@iQQBot
Copy link
Contributor

iQQBot commented Aug 28, 2024

image image

verify I can access both regular workspace page, and debug workspace page

@geropl
Copy link
Member

geropl commented Aug 28, 2024

@mustard-mh Code LGTM!

How confident are you in this change not breaking anything? Could it be worth it to add a feature flag? (My gut feeling: not necessary, but wanted to make sure with you)

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with your testing steps, looks great :shipit:

I'm a proponent of a feature flag if it's not too much of a hassle

@mustard-mh mustard-mh requested a review from a team as a code owner August 28, 2024 09:57
@mustard-mh mustard-mh requested a review from a team as a code owner August 28, 2024 10:54
@mustard-mh
Copy link
Contributor Author

mustard-mh commented Aug 28, 2024

PR is blocking by ENT-733 now

@roboquat roboquat added size/L and removed size/M labels Aug 29, 2024
@roboquat roboquat merged commit 309a32e into main Aug 29, 2024
18 checks passed
@roboquat roboquat deleted the hw/ENT-538 branch August 29, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants