-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Improve CORS settings #20154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CORS settings #20154
Conversation
@mustard-mh Code LGTM! How confident are you in this change not breaking anything? Could it be worth it to add a feature flag? (My gut feeling: not necessary, but wanted to make sure with you) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with your testing steps, looks great
I'm a proponent of a feature flag if it's not too much of a hassle
This reverts commit 06624ee.
PR is blocking by ENT-733 now |
Description
Related Issue(s)
Fixes ENT-538
How to test
See internal chat
Preview env should work well
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold